Fix Install to replace stale standalone hooks on path change#13
Merged
Fix Install to replace stale standalone hooks on path change#13
Conversation
Set release-as 1.1.0 for the pull-model distribution migration. Remove release-as after release-please creates the release PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When migrating from standalone binary to plugin installation, the old hook entry in settings.json was never removed. Install() treated any existing gatekeeper hook as "already configured" regardless of path, so the old binary kept running alongside the plugin version. The old binary could be outdated and missing features like cd-prefix handling. Now Install() checks for an exact command match. If a gatekeeper hook exists at a different path, it removes the old one before adding the new entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install()now checks for exact command path match instead of any gatekeeper hook~/.claude/hooks/claude-gatekeeper), it removes the stale entry before installing the new one (e.g., plugin at${PLUGIN_ROOT}/bin/run.sh)Test plan
TestInstallReplacesOldHook— verifies old hook at different path gets replacedTestInstallIdempotentWithSamePath— verifies exact same path is still a no-op🤖 Generated with Claude Code