Fix durable scheduled ceremony delivery - #1009
Conversation
|
Independent read-only review: PASS, no blocking findings. The review specifically re-checked ambiguous Local gates:
GitHub gates:
Operational constraints held: draft only; no merge, activation, watch restart, or flotilla-dev recycle. PR #1008's recycle hold remains untouched. |
|
Addendum folded into this PR at
Independent read-only re-review: PASS, no blocking findings. Gates:
No merge, activation, daemon restart, or flotilla-dev recycle was performed. PR #1008's recycle hold remains untouched. |
|
Hosted gates for addendum head
|
|
Correction applied in The primary defect is ceremony classification, not a general injector delivery-contract defect: the scheduler previously emitted once-daily work as disposable The generalized busy-policy enum, unknown-kind rejection, and queued-string changes from the prior addendum have been removed. A dedicated regression with no artifact configuration proves that a scheduled ceremony is classified as Expected-artifact lifecycle coverage for all four Cos ceremonies remains as independent second-line detection after confirmed delivery; it does not gate enqueue, retry, or the primary classification fix. Independent correction review: PASS, no blocking findings. Fresh gates:
No merge, activation, watcher restart, or recycle performed. |
Summary
Regression coverage
Gates
go test ./...go test -race ./internal/watch ./internal/roster ./cmd/flotillago vet ./...git diff --checkOperational constraints
Nonblocking follow-ups
Summary by cubic
Make scheduled ceremonies durable and correctly classified. Scheduled work now uses
KindScheduled(notKindDetector) so it survives busy panes; artifacts are a second-line check after confirmed delivery.New Features
KindScheduledfor ceremony instructions with busy deferral and single coordinator→adjutant alias; works even with no artifact config.flotilla-schedule-state.json, with pre-attempt receipts and post-accept enqueue timestamps.Bug Fixes
Written for commit 1e7d045. Summary will update on new commits.