Fix ordering and byte size of song position pointer data bytes#28
Merged
Merged
Conversation
Before, SongPointer#data_as_bytes was using 8-bit bytes in big-endian order. But the MIDI spec calls for two 7-bit bytes in little-endian order with LSB first, similar to the pitch bend message. References used: - https://www.midi.org/specifications-old/item/table-1-summary-of-midi-message - jack_midi_dump output from a hardware sequencer
Owner
|
@mike-bourgeous thanks so much for this fix! |
Owner
|
FYI I've published version 4.0.0, including this fix, on RubyGems. Thanks again for your help. |
Contributor
Author
|
Awesome, thanks! Glad to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, SongPointer#data_as_bytes was using 8-bit bytes in big-endian order. But the MIDI spec calls for two 7-bit bytes in little-endian order with LSB first, similar to the pitch bend message.
Related to arirusso/nibbler#5
References used
Before
Note that my program displays new messages at the top, while jack_midi_dump shows new messages at the bottom.
After