Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
===========================================
- Coverage 78.39% 14.78% -63.62%
===========================================
Files 36 36
Lines 2310 2313 +3
===========================================
- Hits 1811 342 -1469
- Misses 499 1971 +1472
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Andrei997
requested review from
delgermurun and
mapleeit
and removed request for
delgermurun
Contributor
Author
|
Let's review this, I'll fix the coverage problem before merging, I'm reporting to the wrong path. |
delgermurun
reviewed
Jan 31, 2023
Contributor
delgermurun
left a comment
delgermurun
left a comment
There was a problem hiding this comment.
Generally looks good to me. But we our latest changes on the API, request/response data shape will be changed.
| # ---------------------------------------------------------------- Test related targets | ||
|
|
||
| PYTEST_ARGS = --show-capture no --full-trace --verbose --cov hubble/ --cov-report term-missing --cov-report xml | ||
| PYTEST_ARGS = --show-capture no --full-trace --verbose --cov hubble/ --cov-report term-missing --cov-report xml |
Contributor
There was a problem hiding this comment.
unnecessary change (' ' at the end of line)
Contributor
Author
There was a problem hiding this comment.
Yeah, I'm moving these two PR's back to draft mode and re-factor after payment v4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early work on CI integration for Hubble Payment.
Work in progress