Skip to content

feat: send docarray v info to backend #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JoanFM wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: send docarray v info to backend #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hubble/executor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ class HubExecutor:
archive_url: Optional[str] = None
md5sum: Optional[str] = None
build_env: Optional[list] = None
jina_version: Optional[str] = None
docarray_version: Optional[str] = None
17 changes: 16 additions & 1 deletion hubble/executor/hubio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,8 +1058,16 @@ def _send_request_with_retry(url, **kwargs):
return resp

pull_url = urljoin(hubble.utils.get_base_url(), 'executor.getPackage')
try:
from jina import __version__ as jina_version
except ImportError:
jina_version = __unset_msg__
try:
from docarray import __version__ as docarray_version
except ImportError:
docarray_version = __unset_msg__

payload = {'id': name, 'include': ['code'], 'rebuildImage': rebuild_image}
payload = {'id': name, 'include': ['code'], 'rebuildImage': rebuild_image, 'jina': jina_version, 'docarray': docarray_version}
if image_required:
payload['include'].append('docker')
if secret:
Expand Down Expand Up @@ -1091,6 +1099,8 @@ def _send_request_with_retry(url, **kwargs):
archive_url=resp['package']['download'],
md5sum=resp['package']['md5'],
build_env=list(buildEnv.keys()) if buildEnv else [],
jina_version=jina_version,
docarray_version=docarray_version
)

@staticmethod
Expand All @@ -1106,6 +1116,10 @@ def deploy_public_sandbox(args: Union[argparse.Namespace, Dict]) -> str:
from jina import __version__ as jina_version
except ImportError:
jina_version = __unset_msg__
try:
from docarray import __version__ as docarray_version
except ImportError:
docarray_version = __unset_msg__

args_copy = copy.deepcopy(args)
if not isinstance(args_copy, Dict):
Expand All @@ -1116,6 +1130,7 @@ def deploy_public_sandbox(args: Union[argparse.Namespace, Dict]) -> str:
'name': name,
'tag': tag if tag else 'latest',
'jina': jina_version,
'docarray': docarray_version,
'args': args_copy,
'secret': secret,
}
Expand Down