fix permission reentrancy#145
Merged
jingjing2222 merged 2 commits intoJul 17, 2026
Merged
Conversation
Owner
|
/e2e |
Contributor
|
@jingjing2222 iOS E2E: success
|
Contributor
|
@jingjing2222 Android E2E: success
|
Owner
|
Thanks for contributing! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a re-entrancy bug in iOS permission handling.
JavaScript callbacks can synchronously re-enter
NitroGeolocation. The implementation now snapshots andclears pending permission resolvers before invoking callbacks, and captures the monitoring decision before
callback execution.
Type of Change
Checklist
E2E Test Results
Not run.
Platform tested:
Test artifacts:
None.
Additional Notes
This is the upstream version of the existing patch for
react-native-nitro-geolocation@1.4.2. I have done localy + is in a published production app in the Appstore.