ci: fix job using cargo clippy instead of cargo check

[tanguysegarra]

Closes #290

[Skallwar]

I think we should use something like this https://github.com/marketplace/actions/rust-clippy-check

[tanguysegarra]

I believe we can trust the action you linked @Skallwar, I'll implement the change later on :) thanks for the tip

[tanguysegarra]

@Skallwar actually, the clippy-check action is already being used in our CI in the clippy.yml workflow.
We should probably either drop this file or remove the cargo check from the build_test_fmt.yml workflow.
I do not see any reason why we need both. What's your opinion on this @Skallwar @CohenArthur?

[CohenArthur]

@Skallwar actually, the clippy-check action is already being used in our CI in the clippy.yml workflow. We should probably either drop this file or remove the cargo check from the build_test_fmt.yml workflow. I do not see any reason why we need both. What's your opinion on this @Skallwar @CohenArthur?

My understanding (but I might be wrong) is that the clippy-check action is used to create these nice looking warnings in the pull request window. However, we still want to run cargo clippy to prevent PRs from being merged should they introduce new clippy warnings

[CohenArthur]

(or cargo check)

[CohenArthur]

LGTM! Thank you :)