Fix case-insensitive field matching when both exported and unexported fields exist #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problem Description
When using case-insensitive field matching,
copiermay incorrectly match unexported fields when the target struct contains both exported (e.g.,State) and unexported fields (e.g.,state) with similar names, leading to copy failures or data loss.This issue is particularly common when working with protobuf-generated structs, as the protobuf compiler generates structs containing both public and private fields.
Reproduction Scenario
In case-insensitive mode,
copiermight match the privatestatefield instead of the publicStatefield, causing copy operations to fail.✅ Solution
Reimplemented the case-insensitive matching logic in the
fieldByNamefunction:Key Improvements
🧪 Test Coverage
Added comprehensive test cases:
📋 Changes
fieldByNamefunction incopier.gocopier_case_insensitive_test.gotest file🔄 Impact
This fix:
📚 Background
This fix addresses field matching ambiguity encountered in real-world projects using
copier, particularly in microservice architectures using protobuf. The solution ensures that when multiple fields match case-insensitively, the library intelligently selects the most appropriate field according to Go's visibility conventions.🧪 Testing
All tests pass, confirming the fix works correctly while maintaining backward compatibility.