feat(bam): Add parent identity to LeaderState - #1652
Draft
0xEdgar wants to merge 1 commit into
Draft
Conversation
Populate the `parent_slot`, `parent_block_id` and `atomic_batches_enabled` fields from jito-labs/bam-protos#18 so BAM can create its bank for the slot before any shred arrives (MEV-12789, MEV-12835). - read the working bank and its readiness from one `SharedLeaderState` snapshot so a same-slot replacement cannot mix them - bump `jito-protos/bam-protos` to the #18 commit
0xEdgar
requested review from
buffalu,
ebin-mathews,
esemeniuc and
haoranjito
September 12, 2026 03:04
buffalu
reviewed
Sep 12, 2026
| @@ -342,6 +344,9 @@ impl BamManager { | |||
| slot: bank.slot(), | |||
| tick: (bank.tick_height() % bank.ticks_per_slot()) as u32, | |||
| slot_cu_budget_remaining, | |||
Contributor
There was a problem hiding this comment.
do we need to add the current bank id here too? i need to read into AG more, but think we need to target the bank slot/bank id when were sending the atomic tx batches so that our speculative bank is built properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate the
parent_slot,parent_block_idandatomic_batches_enabledfields from jito-labs/bam-protos#18 so BAM can create its bank for the
slot before any shred arrives (MEV-12789, MEV-12835).
SharedLeaderStatesnapshot so a same-slot replacement cannot mix them
jito-protos/bam-protosto feat(types): Add bank identity to LeaderState jito-labs/bam-protos#18