ignore if new validator too #612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add GHA to close new issues with a comment * Remove trailing whitespace
Add github action to close new pull requests with a comment directing them to agave
* ci: add upload-gcs-artifact * ci: publish release binaries to GCS * ci: redirect github repo to anza-xyz * ci: publish windows binaries to GCS * replace release.solana.com with release.anza.xyz * use a explicit name for credential
* Update README.md * ci: update CodeCov report link * ci: update github pr link * ci: rename secondary pipeline * replace org name in .mergify * update channel info link * update dependabot pr link * use anza docker image * delete travis --------- Co-authored-by: Will Hickey <[email protected]>
* ci: fix windows build * ci: publish sdk docker image with the new name * update automerge status
…foundation#9) ci: removed unused s3 upload in Windows build
* rename geyser-plugin-interface * rename cargo registry * rename watchtower * rename ledger tool * rename validator * rename install * rename geyser plugin interface when patch
jito-foundation#69) * Make inactive_stake consistent * Add rpc_deprecated_v1_18 module * Move get_stake_activation to deprecated list * Fix typo
This reverts commit 3f9a7a5.
jito-foundation#9)" This reverts commit 91e3dd2.
This reverts commit 58e9a19.
This reverts commit b0022d7.
This reverts commit 9355518.
Signed-off-by: gcmutator <[email protected]>
This reverts commit 556a749.
When viewing in various tools such as gdb and perf, it is not easy to distinguish which threads are serving which function (TPU or TPU FWD)
- solTvuFetchPmod ==> solTvuPktMod + solTvuRepPktMod - solSigVerifier ==> solSigVerTpu + solSigVerTpuVot
* Simplify vote-authority display * Add handling for new vote authority * Add proper None handling, because unit test (shouldn't happen IRL, though) * Unwrap->expect
* assert simple vote tx const cost
segfaultdoc
reviewed
May 27, 2024
| { | ||
| match e { | ||
| // This error is frequent on hot spares, and the parsed string does not work | ||
| // This error is frequent on hot spares and on new validators, and the parsed string does not work |
Contributor
There was a problem hiding this comment.
@michaelschem can you add context that new validator is not on leader schedule?
buffalu
force-pushed
the
master
branch
3 times, most recently
from
7bc716a to
b8605f2
Compare
buffalu
force-pushed
the
master
branch
4 times, most recently
from
6a0aa5b to
8d53d7b
Compare
buffalu
force-pushed
the
master
branch
3 times, most recently
from
75c3a1c to
d7f139c
Compare
buffalu
force-pushed
the
master
branch
5 times, most recently
from
56e55ae to
0b061cc
Compare
buffalu
force-pushed
the
master
branch
2 times, most recently
from
d7af5ef to
fadc825
Compare
buffalu
force-pushed
the
master
branch
2 times, most recently
from
96e2c08 to
042f9c1
Compare
buffalu
force-pushed
the
master
branch
2 times, most recently
from
02db91d to
1d4355b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
34 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Error says to ignore if you're a hot-spare, but you should also ignore if you're a new validator because you're not yet on the leader schedule.
Summary of Changes
Add some text to the error message.