Alerts for Merkle Root Upload and Claims #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzalz
reviewed
Aug 12, 2025
tip-router-operator-cli/src/claim.rs
Outdated
| .await?; | ||
|
|
||
| if validators_processed { | ||
| let epoch_percentage = epoch_percentage::get(&rpc_client).await.unwrap_or(0f64); |
Contributor
There was a problem hiding this comment.
I believe we'd want to not emit in the event of the unwrap failing so that we're not erroneously writing 0% in the event of a 429 or timeout. Thoughts?
Contributor
Author
There was a problem hiding this comment.
I'm with that. Best to avoid erroneous alerts.
ebatsell
reviewed
Aug 12, 2025
| @@ -0,0 +1,10 @@ | |||
| use anyhow::Result; | |||
Collaborator
There was a problem hiding this comment.
Nit: would prefer this as just a helper in lib.rs than adding another file
ebatsell
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new "epoch_percentage" field (already used elsewhere), in creating new alerts for Merkle Root Uploads and MEV/PF Claims.
Three new alerts:
"Tip Router -- Merkle Root Upload Timer" https://jitolabs.grafana.net/alerting/grafana/beub9k1y9dfcwd/view
Alerts if the number of failed MR uploads has not reached zero after 10% of the epoch.
"Tip Router -- Claims Timer" https://jitolabs.grafana.net/alerting/grafana/beub9k1y9dfcwd/view
Alerts if the number of remaining claims has not reached zero after 33% of the epoch.
"Tip Router -- Claims Have Stalled" https://jitolabs.grafana.net/alerting/grafana/fetnet1krxatcf/view
Checks the num remaining claims now vs an hour ago, and alerts if those values are the same.