operator: improve error handling in critical path #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzalz
commented
Nov 10, 2025
| OperatorState::CastVote => { | ||
| let meta_merkle_tree_path = | ||
| meta_merkle_tree_path(epoch_to_process, &cli.get_save_path()); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is the big one. Any panic that killed the main process on an external validator was coming from here. The tokio task that submits to NCN from main.rs is properly handled. This is not.
mrmizz
previously approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Internal and external operators have seen transient errors crashing tip router operator. These errors are generally related to a timed out RPC request. Upon examining loop_stages I have found errors that perhaps are not handled in the way we would like.
Solution:
?, log an error here, this gives the operator a chance to vote again and recover from any potential RPC issues that were responsible for the failure.