Using PreciseNumber for underlaying calculations #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebatsell
reviewed
Nov 7, 2024
core/src/precise_numbers.rs
Outdated
Comment on lines
95
to
101
| pub fn token_supply_to_precise_number( | ||
| token_supply: u64, | ||
| ) -> Result<PreciseNumber, TipRouterError> { | ||
| let value = Self::from_token_supply(token_supply)?; | ||
|
|
||
| value.number.to_precise_number() | ||
| } |
Collaborator
There was a problem hiding this comment.
this method is slightly different than the PreciseWeight version of it -- can we keep it standard so these wrappers are more intuitive to interact with
Collaborator
Author
There was a problem hiding this comment.
Make into PodPreciseNumber
use from and into
ebatsell
reviewed
Nov 7, 2024
ebatsell
reviewed
Nov 7, 2024
ebatsell
approved these changes
Nov 8, 2024
Collaborator
ebatsell
left a comment
ebatsell
left a comment
There was a problem hiding this comment.
LGTM once tests are passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All arithmetic should be done using PreciseNumber