API: Use Option type for running_bam
#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the running_bam field from a required boolean (bool) to an optional boolean (Option<bool>) across the database model and API schema to better handle cases where BAM client information may be unavailable.
- Changed
running_bamfield type frombooltoOption<bool>in theValidatorstruct - Updated API schema's
ValidatorEntryto useOption<bool>forrunning_bam - Modified initialization to wrap the boolean value with
Some()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/src/db_models/validators.rs | Changed running_bam field to Option<bool> in the Validator struct and wrapped the assignment with Some() |
| api/src/schemas/validator.rs | Changed running_bam field to Option<bool> in the ValidatorEntry schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ggnine-jito
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.