Skip to content

Conversation

@aoikurokawa
Copy link
Collaborator

@aoikurokawa aoikurokawa commented Nov 11, 2025

  • Use BAM api

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates the BAM API client to improve BAM validator detection by querying the BAM Explorer API instead of relying solely on validator history client type information.

Key Changes:

  • Added BAM API client integration to fetch validators from the BAM Explorer API
  • Updated BAM client detection logic to prioritize API data over validator history client types
  • Added new optional bam_api_base_url configuration parameter throughout the application

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
writer-service/src/stake_pool_manager.rs Integrated BamApiClient as optional field, fetches validator set from BAM API
writer-service/src/result.rs Added BamApiError to AppError enum for error handling
writer-service/src/main.rs Added bam_api_base_url CLI argument
writer-service/src/lib.rs Threaded bam_api_base_url parameter to StakePoolManager
core/src/fetcher.rs Updated BAM detection logic to use API validator set when available
writer-service/Cargo.toml Added bam-api-client dependency
core/Cargo.toml Added bam-api-client dependency
Cargo.toml Added bam-api-client dependency and upgraded solana-metrics
Cargo.lock Updated dependencies including bam-api-client, solana-metrics, and transitive dependencies
docker-compose.yml Added BAM_API_BASE_URL environment variable to services

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aoikurokawa aoikurokawa marked this pull request as ready for review November 11, 2025 18:51
@aoikurokawa aoikurokawa merged commit abaddf9 into master Nov 11, 2025
5 checks passed
@aoikurokawa aoikurokawa deleted the ak/running_bam branch November 11, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants