fix(auto): the spawn retry window was shorter than the thing it covers - #235
Merged
Conversation
#214 gave the assessor a bounded spawn retry and #226 extended it to the planner. Both shipped at 3 attempts, 300ms apart -- a 600ms window -- and two more lanes died on the same failure AFTER that shipped: assessor run: claude run: spawn failed: exec: "claude": executable file not found in $PATH planner run: claude run: spawn failed: exec: "claude": executable file not found in $PATH Four occurrences in one day, two of them post-fix. 600ms is less than a package manager takes to relink a binary, so the retry was correct in shape and useless in size. 5 attempts, 2s apart. A machine that genuinely lacks the CLI still fails -- eight seconds later, saying what it said before. Only a spawn that never happened is retried; a refused reply, a non-zero exit, a timeout and a cancelled context all still stop on the first answer. Co-Authored-By: oh-my-graph <graphs@oh-my-graph.dev> Signed-off-by: jitokim <pigberger70@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#214 gave the assessor a bounded spawn retry; #226 extended it to the planner. Both shipped at 3 attempts, 300ms apart — a 600ms window — and two more lanes died on the same failure after that shipped.
Four occurrences in one day, two of them post-fix. 600ms is less than a package manager takes to relink a binary, so the retry was correct in shape and useless in size.
Widened to 5 attempts, 2s apart — eight seconds of patience.
A machine that genuinely has no CLI installed still fails, eight seconds later, saying exactly what it said before. And nothing about reply handling changed: only a spawn that never happened is retried; a refused reply, a non-zero exit, a timeout and a cancelled context all still stop on the first answer.
The comment in
assess.gonow carries the two post-fix failures verbatim, so the next person to think 600ms is enough has the counter-evidence in front of them.🤖 Generated with Claude Code