Conversation
ADR 0029 folded lane A into one `use: gated-lane` node, and commit d232ce4 deleted the `dev-a`/`e2e-a`/`review-a`/`pr-a` nodes — but its diff on this file starts at line 45, so the header above kept naming them. The runtime ids are `lane-a/dev`, `lane-a/e2e`, `lane-a/review`, `lane-a/pr`, as the file's own body comment says at line 88 and `--dry-run` prints. Rule 1's advice was worse than stale: "make dev-b depend on pr-a" is a load error (`depends_on unknown node`, internal/graph/validate.go:454), so a reader who followed it got a graph that would not load. `init` emits this file and users copy it, so both lines were instructions to a stranger. Comments only — no node, prompt or key changed; the graph still validates at 8 nodes. Co-Authored-By: oh-my-graph <graphs@oh-my-graph.dev> Signed-off-by: jitokim <pigberger70@gmail.com>
Comments-only edit to one shipped graph, filed under Unreleased/Documented with the dry-run command that names the eight real node ids, so the claim has an address a reader can re-run. States the negative result too: the other thirteen graphs and fragments were audited against v0.11.0 and left untouched, none of them naming `auto`. Co-Authored-By: oh-my-graph <graphs@oh-my-graph.dev> Signed-off-by: jitokim <pigberger70@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # graphs/backlog-batch.yaml
The conflict was real content on both sides. #236 added the disposition prose to rule 1; d3 corrected the node this file names. 'pr-a' does not exist -- lane-a is a 'use: gated-lane' node, so the id is 'lane-a/pr', which is what the lint prints when it splices the fragment. Co-Authored-By: oh-my-graph <graphs@oh-my-graph.dev> Signed-off-by: jitokim <pigberger70@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A v0.11.0 re-read of the eight shipped graphs and six fragments.
Almost everything was clean, and the write-up says so rather than inventing work — these files were audited five days ago and the brief was explicit that "clean" is a real result.
The one real find is the kind that matters:
backlog-batch.yaml's header diagrammed four nodes that no longer exist.initemits these graphs and users copy them, so a header that has drifted from its own node list is a stale instruction to a stranger.🤖 Generated with Claude Code