Add ppc64le cross-compilation support by fitzsim · Pull Request #9 · jitsi/dcsctp4j

fitzsim · 2025-02-11T03:18:00Z

I tested:

export JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
resources/ubuntu-build-all.sh ~/depot_tools ~/WebRTC

on x86-64 Debian 12. x86-64 and aarch64 libraries built as before, and the ppc64le cross-compilation succeeded. I tested the new library:

dcsctp4j/src/main/resources/linux-ppc64le/./libdcsctp4j.so

on my Debian 12 ppc64le Jitsi installation and it worked when I initiated a two-party meeting:

JVB 2025-02-10 22:02:53.029 INFO: [50] DcSctp4j.<clinit>#38: DcSctp4j lib loaded

I made ninja verbose so that its compiler arguments are available in continuous integration logs for comparison with those specified by the new Makefile.

The other two ubuntu-build.sh changes reorder some lines in preparation for the addition of the ppc64le logic.

JonathanLennox · 2025-02-11T21:26:55Z

resources/ubuntu-build.sh

    echo "  DEPOT_TOOLS_DIR: Directory containing Google depot tools"
    echo "  WEBRTC_DIR: Directory containing WebRTC source"
-    echo "  ARCH: Architecture to build for (x86_64 or arm64)"
+    echo "  ARCH: Architecture to build for (x86_64 or arm64 or ppc64le)"


Should be a comma-separated list: (x86_64, arm64, or ppc64le). Your choice whether to use the Oxford comma.

JonathanLennox · 2025-02-11T21:29:55Z

resources/Makefile.2

@@ -0,0 +1,55 @@
+# Build libdcsctp.a on non-"gn" supported architectures


You seem to have also checked in a Makefile.2 -- was this a mistake?

Yes, removed.

JonathanLennox · 2025-02-11T21:33:34Z

resources/Makefile

+CXXFLAGS += -I $(S)/third_party/crc32c/src/include
+# Assume all non-test .cc files under net/dcsctp are needed by libdcsctp4j.so.
+# "gn/ninja" includes 43 extra objects but they are not needed by
+# libdcsctp4j.so.


I'd like to verify that that dcsctp4j still links at -O0 (which may be needed for debugging) with just this list of files? It's possible that some dependencies from those 43 extra objects get optimized out.

I found a few missing symbols with:

nm --demangle -D dcsctp4j/src/main/resources/linux-ppc64le/libdcsctp4j.so | grep ' U ' | grep -v @

I added six extra objects required to define them.

I added a debug argument to ubuntu-build.sh to test this. libdcsctp4j.so built with -O0 works on my ppc64le Jitsi setup.

JonathanLennox · 2025-02-11T21:36:06Z

resources/Makefile

+# Assume all non-test .cc files under net/dcsctp are needed by libdcsctp4j.so.
+# "gn/ninja" includes 43 extra objects but they are not needed by
+# libdcsctp4j.so.
+TESTS = $(wildcard $(S)/net/dcsctp/*/*_test.cc $(S)/net/dcsctp/*/*/*_test.cc)


There's also common/handover_testing.cc which doesn't match this pattern. I think if you make the pattern *_test*.cc you'll match that file as well.

JonathanLennox · 2025-02-11T21:38:08Z

resources/ubuntu-build.sh

 rm -rf $WEBRTC_BUILD
-gn gen $WEBRTC_BUILD --args="use_custom_libcxx=false target_cpu=\"$GN_ARCH\" is_debug=false symbol_level=2"
-ninja -C $WEBRTC_BUILD dcsctp
+if test -z "$GNU_ARCH"; then


I'm not crazy about having this choice be implicit based on the presence or absence of GNU_ARCH; can you have something like an explicit BUILD_DCSCTP_WITH_MAKEFILE argument instead?

Done, as an argument to ubuntu-build.sh.

Add a Makefile that can be used to cross-compile libdcsctp.a for architectures that "gn" does not support.

fitzsim · 2025-02-14T10:09:07Z

Thank you for reviewing. I addressed all your comments, and added optional verbose and debug support as extra commits. To keep the history clean but keep discussion on the same pull request I force-pushed the branch, so you will have to check it out again.

This reverts commit 3f09928.

JonathanLennox · 2025-02-19T01:59:57Z

Unfortunately this PR didn't work after I merged it, so I've reverted it.

There were a few problems:

The command line for making the objdirs resulted in

make: execvp: /bin/sh: Argument list too long

because all the object directories were on a single command line and our paths on our build machine are fairly deep.

The wildcard pattern

$(wildcard $(S)/*/ $(S)/*/*/ $(S)/*/*/*/ $(S)/*/*/*/*/ $(S)/*/*/*/*/*/)

matched things that weren't directories -- this is possibly a bug in the version of glibc's glob on our build machine's Ubuntu Focal release, and possibly a cause for problem 1 (because OBJDIRS ended up much larger).

As mentioned our build machine is Ubuntu Focal, so it has GCC 9, which doesn't have two of the command-line arguments you included: -ftrivial-auto-var-init=pattern and -Wctad-maybe-unsupported. I think both of these are safely omittable.

I can do PRs against your branch to fix all three of those; however you'll need to open a new PR against dcsctp4j, because it doesn't look like GitHub has any way to re-open a merged PR.

fitzsim · 2025-02-19T03:13:20Z

OK, I pushed a rebased redo branch, https://github.com/fitzsim/dcsctp4j/tree/ppc64le-support-4. Do you want to send me pull requests against that before I submit it as a new pull request?

JonathanLennox · 2025-02-19T17:01:09Z

I have my pull requests against your branch at fitzsim#2

fitzsim · 2025-02-19T18:16:48Z

Resubmitted as #11, thank you.

fitzsim mentioned this pull request Feb 11, 2025

Add ppc64le cross-compilation support #8

Closed

JonathanLennox reviewed Feb 11, 2025

View reviewed changes

fitzsim added 6 commits February 14, 2025 04:50

ubuntu-build.sh: Set MAKE_ARGS earlier

da4e54a

ubuntu-build.sh: Move sysroot install later

178e0a9

resources/Makefile: New file

f63d0b9

Add a Makefile that can be used to cross-compile libdcsctp.a for architectures that "gn" does not support.

Add ppc64le cross-compilation support

698ecff

ubuntu-build.sh: Add verbose support

3f020d6

ubuntu-build.sh: Add debug optimization level

3aa9332

fitzsim force-pushed the ppc64le-support-2 branch from 2d0dcd6 to 3aa9332 Compare February 14, 2025 09:59

JonathanLennox approved these changes Feb 18, 2025

View reviewed changes

JonathanLennox merged commit 3f09928 into jitsi:main Feb 18, 2025

JonathanLennox added a commit that referenced this pull request Feb 18, 2025

Revert "Add ppc64le cross-compilation support (#9)"

781d377

This reverts commit 3f09928.

JonathanLennox mentioned this pull request Feb 18, 2025

Revert "Add ppc64le cross-compilation support" #10

Merged

JonathanLennox added a commit that referenced this pull request Feb 18, 2025

Revert "Add ppc64le cross-compilation support (#9)" (#10)

5b58e75

This reverts commit 3f09928.

fitzsim mentioned this pull request Feb 18, 2025

Ship libdcsctp4j.so for ppc64le #6

Open

		@@ -0,0 +1,55 @@
		# Build libdcsctp.a on non-"gn" supported architectures

Conversation

fitzsim commented Feb 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fitzsim Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fitzsim commented Feb 14, 2025

Uh oh!

JonathanLennox commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fitzsim commented Feb 19, 2025

Uh oh!

JonathanLennox commented Feb 19, 2025

Uh oh!

fitzsim commented Feb 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fitzsim Feb 14, 2025 •

edited

Loading

JonathanLennox commented Feb 19, 2025 •

edited

Loading