Fixed wrong link in iframe.md #556
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe had a link to the react sdk documentation which was incorrect (https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe/dev-guide-react-sdk). I fixed the link (https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe/dev-guide-react-sdk).
|
The link is relative to the current path and is working as expected in the handbook |
When I am directed to https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe/dev-guide-react-sdk I see this: https://imgur.com/a/v8jRl1V |
|
Hum, am I doing it wrong? I go to this page |
|
FWIW I get the same behavior as OP, aka page not found. That said, the proposed fix is not good, it should be the document ID and docusaurus generates de right link. Unless there is a bug lurking somewhere... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe had a link to the react sdk documentation which was incorrect (https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-iframe/dev-guide-react-sdk). I fixed the link (https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-react-sdk/).