Add IMDSv2 support to AwsCandidateHarvester and replace URLConnection… #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with HttpRequest
|
Can we set a short timeout so it doesn't hang for a long time when it runs outside AWS? |
|
@bgrozev added |
bgrozev
approved these changes
Dec 4, 2024
|
Thank you! I just noticed that OCI also supports IMDSv2 and that address responds, so it ends up with RUNNING_ON_EC2=true. But that's unrelated to the PR. |
bgrozev
added a commit
to bgrozev/jitsi-videobridge
that referenced
this pull request
Dec 5, 2024
* fix: Fail early if IMDS returns an error. (jitsi/ice4j#298) * Add IMDSv2 support to AwsCandidateHarvester and replace URLConnectionn with HttpRequest (jitsi/ice4j#297) * Add Java 21 to GitHub testing matrix (jitsi/ice4j#296)
bgrozev
added a commit
to jitsi/jitsi-videobridge
that referenced
this pull request
Dec 12, 2024
* fix: Fail early if IMDS returns an error. (jitsi/ice4j#298) * Add IMDSv2 support to AwsCandidateHarvester and replace URLConnectionn with HttpRequest (jitsi/ice4j#297) * Add Java 21 to GitHub testing matrix (jitsi/ice4j#296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with HttpRequest