Skip to content

feat: Option to send to the last received from address.#305

Merged
bgrozev merged 3 commits intojitsi:masterfrom
bgrozev:send-to-last-received-from-address
Nov 25, 2025
Merged

feat: Option to send to the last received from address.#305
bgrozev merged 3 commits intojitsi:masterfrom
bgrozev:send-to-last-received-from-address

Conversation

@bgrozev
Copy link
Copy Markdown
Member

@bgrozev bgrozev commented Nov 24, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.73%. Comparing base (f3db829) to head (bf91c52).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/ice4j/ice/Component.java 5.40% 35 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #305      +/-   ##
============================================
- Coverage     35.86%   35.73%   -0.13%     
+ Complexity     1123     1119       -4     
============================================
  Files           166      166              
  Lines         10958    10988      +30     
  Branches       1618     1626       +8     
============================================
- Hits           3930     3927       -3     
- Misses         6494     6525      +31     
- Partials        534      536       +2     
Files with missing lines Coverage Δ
src/main/kotlin/org/ice4j/ice/AgentConfig.kt 100.00% <100.00%> (ø)
src/main/java/org/ice4j/ice/Component.java 38.40% <5.40%> (-2.53%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3db829...bf91c52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

throws IOException
{
CandidatePair pair = getSelectedPair();
CandidatePair pair = findPair(lastReceivedFrom);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of this code is confusing in the case when send-to-last-received-from-address isn't set.

Comment thread src/main/java/org/ice4j/ice/Component.java
Comment thread src/main/kotlin/org/ice4j/ice/AgentConfig.kt Outdated
@bgrozev bgrozev merged commit c2cbf61 into jitsi:master Nov 25, 2025
4 of 6 checks passed
bgrozev added a commit to jitsi/jitsi-videobridge that referenced this pull request Nov 25, 2025
* Update github action versions (jitsi/ice4j#301)
* Update publishing to Maven central. (jitsi/ice4j#303)
* log: Move verbose logs from INFO to DEBUG. (jitsi/ice4j#300)
* fix: Fail connectivity checks for non-keep-alive pairs (jitsi/ice4j#304)
* feat: Option to send to the last received from address. (jitsi/ice4j#305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants