task: pass through exclusive tenant tag #241
Open
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanaianc
reviewed
Aug 18, 2023
| {% endfor %} | ||
| {% for item in haproxy_facts.backends|sort(attribute='local',reverse=True) %} | ||
| {% if item['release_number'] != release %} | ||
| {% if item['release_number'] != release and item['exclusive_tenant'] == "" %} |
There was a problem hiding this comment.
Isn't the new logic for when the item['exclusive_tenant'] != "" not item['exclusive_tenant'] == "" ?
I don't completely understand it, that's why I'm not sure
There was a problem hiding this comment.
we have replaced one loop for two. Previously, we'd loop on all shards in releases that don't match the current one. Now we loop on all shards that don't match the current release and don't have an exclusive tenancy. Then we go back and loop again and include any that have an exclusive tenancy but aren't part of the current release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.