add whisper to autoscaler #652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronkvanmeerten
requested changes
Dec 11, 2024
ansible/build-gpu-oracle.yml
Outdated
| - { role: "gpu-docker-pull", tags: "gpu-docker", gpu_docker_type: "skynet" } | ||
| - { role: "gpu-docker-pull", tags: "gpu-docker", gpu_docker_type: "whisper" } | ||
| - { role: "streaming-whisper", tags: "gpu-docker", gpu_docker_type: "whisper" } | ||
| - { role: "autoscaler-sidecar", tags: "autoscaler-sidecar", |
There was a problem hiding this comment.
This role is already included in the base image that GPU comes from, so no need to install it here.
ansible/build-gpu-oracle.yml
Outdated
| - { role: "gpu-docker-pull", tags: "gpu-docker", gpu_docker_type: "whisper" } | ||
| - { role: "streaming-whisper", tags: "gpu-docker", gpu_docker_type: "whisper" } | ||
| - { role: "autoscaler-sidecar", tags: "autoscaler-sidecar", | ||
| autoscaler_instance_type: "streaming-whisper", autoscaler_install_flag: true, autoscaler_configure_flag: false, jitsi_autoscaler_sidecar: true} |
There was a problem hiding this comment.
This is a shared image for both skynet ande whisper, so we wouldn't want to set the instance type here.
| @@ -0,0 +1,13 @@ | |||
| - name: Install dependencies | |||
| ansible.builtin.package: | |||
There was a problem hiding this comment.
It's fine to include these, but just FYI they should both be already installed in the base image so this will be a no-op.
| jigasi_transcriber_whisper_private_key: "replaceme" | ||
| jigasi_transcriber_whisper_private_key_name: "replaceme" | ||
| jigasi_transcriber_whisper_websocket_url: "wss://{{ hcv_environment }}-{{ oracle_region }}-whisper.jitsi.net:443/streaming-whisper/ws/" | ||
| jigasi_transcriber_whisper_websocket_url: "wss://{{ hcv_environment }}-{{ oracle_region }}-whisper.jitsi.net:443/whisper/ws/" |
There was a problem hiding this comment.
this is totally unrelated and will breake existing deployments if it's not supported in live whisper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.