Make finalize-script optional for file recordings - #596
Open
thisisnkc wants to merge 4 commits into
Open
Conversation
Megred commits behind the source branch
Remove the dummy default '/path/to/finalize' and skip creating the finalize command runner when no script is configured.
|
Hi, thanks for your contribution! |
saghul
reviewed
Apr 10, 2026
Member
|
The idea SGTM, can't comment much on the code. |
The switch to optionalconfig dropped the legacy JSON config source (finalize_recording_script_path), breaking backward compatibility.
Author
|
I missed on the backward compatibility, should we add tests for that as I can see there are none currently? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make finalize-script optional
The
finalize-scriptinreference.confhad a dummy default (/path/to/finalize) which meant every deployment had to override it, even if they didn't need a finalize script at all.This changes it so the property is optional i.e, if you don't set it, Jibri just skips finalization and moves on. Empty strings are also handled the same way.
No breaking changes, existing setups that already configure a finalize script will work exactly as before.