fix: Security fixes — logging, TLS, Jackson, chromedriver log path#601
Open
bgrozev wants to merge 6 commits intojitsi:masterfrom
Open
fix: Security fixes — logging, TLS, Jackson, chromedriver log path#601bgrozev wants to merge 6 commits intojitsi:masterfrom
bgrozev wants to merge 6 commits intojitsi:masterfrom
Conversation
Full XmppEnvironmentConfig includes usernames and domains. Log only the environment name and host.
JibriConfig includes XmppEnvironmentConfig entries which contain XMPP credential objects. Log only a success confirmation.
Service start log lines included callLoginParams (XMPP credentials) and rtmpUrl (may contain stream key). Log only session ID and call params.
2.9.5 has multiple known CVEs (polymorphic deserialization, etc.). Replace deprecated MissingKotlinParameterException with MismatchedInputException to fix -Werror compilation with 2.19.4.
Set SSLContext.getDefault() on the Apache engine to make certificate validation intentional rather than an implicit JVM default.
/tmp is world-writable and allows symlink attacks. The Jibri log directory is owned by the jibri user and not world-writable.
damencho
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XmppApiJibriConfigJibriManagerservice start methodsSSLContext.getDefault()) inWebhookClientMissingKotlinParameterExceptionwithMismatchedInputException/var/log/jitsi/jibri/instead of world-writable/tmpThese are all best-practice, no known impact.