Skip to content

feat(mediajson): Add optional parameters to MediaFormat. #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgrozev merged 2 commits into from
Feb 10, 2026
+5 −2
Merged

feat(mediajson): Add optional parameters to MediaFormat. #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7994112
feat(mediajson): Add optional parameters to MediaFormat.
bgrozev Feb 9, 2026
a58cf26
test: Add tests for params.
bgrozev Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jicoco-mediajson/src/main/kotlin/org/jitsi/mediajson/MediaJson.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ class SessionEndEvent : Event("session-end")
data class MediaFormat(
val encoding: String,
val sampleRate: Int,
val channels: Int
val channels: Int,
var parameters: Map<String, String>? = null
)
data class Start(
val tag: String,
Expand Down
4 changes: 3 additions & 1 deletion jicoco-mediajson/src/test/kotlin/org/jitsi/mediajson/MediaJsonTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ class MediaJsonTest : ShouldSpec() {
val enc = "opus"
val sampleRate = 48000
val channels = 2
val event = StartEvent(seq, Start(tag, MediaFormat(enc, sampleRate, channels)))
val params = mapOf("k1" to "v2", "k2" to "v2")
val event = StartEvent(seq, Start(tag, MediaFormat(enc, sampleRate, channels, params)))

context("Serializing") {
val parsed = parser.parse(event.toJson())
Expand All @@ -52,6 +53,7 @@ class MediaJsonTest : ShouldSpec() {
mediaFormat["encoding"] shouldBe enc
mediaFormat["sampleRate"] shouldBe sampleRate
mediaFormat["channels"] shouldBe channels
mediaFormat["parameters"] shouldBe params
}
context("Parsing") {
val parsed = Event.parse(event.toJson())
Expand Down