Skip to content

Fix security findings: info disclosure, lockfile, DoS guards#5

Open
bgrozev wants to merge 5 commits intomainfrom
fix/info-disclosure-logging
Open

Fix security findings: info disclosure, lockfile, DoS guards#5
bgrozev wants to merge 5 commits intomainfrom
fix/info-disclosure-logging

Conversation

@bgrozev
Copy link
Copy Markdown
Member

@bgrozev bgrozev commented Apr 26, 2026

Summary

  • Redact conference IDs (SHA-256 8-char prefix) and conference names from logs; strip URL credentials before logging configured endpoints; log only e.message on fetch errors
  • Remove package-lock.json from .gitignore and commit it for reproducible installs and supply-chain auditability
  • Guard sendData against null/disconnected WebSocket to prevent process crash
  • Replace endpoints array with Set in conference state for O(1) dedup and cleaner memory behaviour

bgrozev added 5 commits April 26, 2026 17:51
Add npm overrides to enforce patched versions of transitive
dependencies with ReDoS/prototype-pollution vulnerabilities.
- Hash conference IDs with SHA-256 (8-char prefix) for log
  correlation without plaintext disclosure
- Strip URL credentials before logging configured endpoints
- Log only error message on fetch failure, not full error object
Replaces the endpoints array with a Set: O(1) has() vs O(n) indexOf,
and prevents the accumulation of duplicate entries over time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant