Skip to content

Conversation

@damencho
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes missing coverage. Please review.

Project coverage is 19.23%. Comparing base (03d83b3) to head (940d4fc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...org/jitsi/jigasi/xmpp/CallControlMucActivator.java 0.00% 10 Missing ⚠️
.../main/java/org/jitsi/jigasi/SipGatewaySession.java 18.18% 7 Missing and 2 partials ⚠️
.../java/org/jitsi/jigasi/AbstractGatewaySession.java 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #604      +/-   ##
============================================
- Coverage     19.24%   19.23%   -0.02%     
- Complexity      309      310       +1     
============================================
  Files            83       83              
  Lines          7143     7168      +25     
  Branches        944      951       +7     
============================================
+ Hits           1375     1379       +4     
- Misses         5541     5561      +20     
- Partials        227      228       +1     
Files with missing lines Coverage Δ
...rc/main/java/org/jitsi/jigasi/AbstractGateway.java 65.16% <100.00%> (-2.28%) ⬇️
.../java/org/jitsi/jigasi/AbstractGatewaySession.java 57.14% <0.00%> (-5.36%) ⬇️
.../main/java/org/jitsi/jigasi/SipGatewaySession.java 44.61% <18.18%> (-0.79%) ⬇️
...org/jitsi/jigasi/xmpp/CallControlMucActivator.java 11.91% <0.00%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d83b3...940d4fc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


response.setUri("xmpp:" + room.getIdentifier() + "/" + room.getUserNickname());
// room can be null when the meeting is not live yet
if (room != null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a log message when room==null, in case it happens unexpectedly?

@damencho damencho merged commit 37d0eab into master Jul 22, 2025
4 of 5 checks passed
@damencho damencho deleted the go-live-outgoing-calls branch July 22, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants