fix: remove leading and trailing dashes from the resource ident#614
Open
wfleischer wants to merge 1 commit intojitsi:masterfrom
Open
fix: remove leading and trailing dashes from the resource ident#614wfleischer wants to merge 1 commit intojitsi:masterfrom
wfleischer wants to merge 1 commit intojitsi:masterfrom
Conversation
Sanitize the resource identifier by removing leading/trailing dashes. This prevents a fatal XmppStringprepException in Jicofo when it generates a Jingle session-initiate that includes a participant whose nickname starts with a hyphen, which is invalid for a JID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitize the resource identifier by removing leading/trailing dashes. This prevents a fatal XmppStringprepException in Jicofo when it generates a Jingle session-initiate that includes a participant whose nickname starts with a hyphen, which is invalid for a JID.