Skip to content

feat: context isolation support and robust IPC (issue #337)#478

Open
4rayaditya wants to merge 1 commit intojitsi:masterfrom
4rayaditya:master
Open

feat: context isolation support and robust IPC (issue #337)#478
4rayaditya wants to merge 1 commit intojitsi:masterfrom
4rayaditya:master

Conversation

@4rayaditya
Copy link
Contributor

This PR refactors the SDK to fully support Electron’s context isolation, following modern security best practices. It introduces a preload script, secure IPC handlers, and a clear integration pattern for all SDK features.

Key Changes

Context Isolation Ready:

  • All SDK APIs are now exposed to the renderer via [preload.js] using [contextBridge].
  • No direct Node.js/Electron access from the renderer; all communication is via IPC.

Main Process IPC Handlers:

  • Added [electron-sdk-ipc.js] to handle all SDK feature requests (screen sharing, remote control, always-on-top) securely in the main process.
  • Real always-on-top window logic and logging for visible testing and debugging.

Example Integration:

  • Provided a minimal test app and renderer example (not included in final commit unless requested) to demonstrate and verify the new integration pattern.

Bug Fixes & Lint:

  • Fixed all import, constructor, and lint errors.
  • Codebase passes all lint checks.

Testing

  • Verified all features work with context isolation enabled.
  • Manual test app demonstrates successful IPC and UI integration.
  • Terminal logs confirm handler activity.
Screenshot 2025-11-22 025253

- Refactored SDK to fully support Electron context isolation using preload.js and contextBridge.
- Added secure, serializable APIs for screen sharing, remote control, and always-on-top features.
- Implemented main process IPC handlers in electron-sdk-ipc.js for all SDK features.
- Fixed all import, constructor, and lint errors.
- Added logging and demo always-on-top window for visible testing.
- Verified integration with a minimal Electron test app.
@4rayaditya
Copy link
Contributor Author

@damencho @saghul I have tried to address the issue #337 through this PR. Please check.

@saghul
Copy link
Member

saghul commented Nov 27, 2025

Thanks for getting this started @4rayaditya !

We are in the process of refactoring the SDK to deal with some Electron 38 changes, so alas we cannot take these changes as they are today.

We'll get back to this issue in due time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants