Skip to content

feat(sdk) update to SDK 9 and Electron 39#1057

Merged
csett86 merged 2 commits intomasterfrom
sdk-9
Dec 27, 2025
Merged

feat(sdk) update to SDK 9 and Electron 39#1057
csett86 merged 2 commits intomasterfrom
sdk-9

Conversation

@saghul
Copy link
Member

@saghul saghul commented Dec 19, 2025

SDK 9 contains a new implementation of the Always on Top window which
uses the native browser Picture-in-Picture support.

@saghul
Copy link
Member Author

saghul commented Dec 19, 2025

@damencho Does the latest meet release include Hristo's PiP implementation?

@damencho
Copy link
Member

Yes 👍

@saghul
Copy link
Member Author

saghul commented Dec 19, 2025

Yes 👍

Great! Then we should be able to inlcude this commit in the next release @csett86 .

SDK 9 contains a new implementation of the Always on Top window which
uses the native browser Picture-in-Picture support.
@csett86
Copy link
Member

csett86 commented Dec 26, 2025

@saghul I tested it with macOS 15.7 and there the always-on-top / new pip does not work. Other than that, please fix the one nit from the linter, and I would still merge it anyway. If the pip is not working, I would accept that for the time being

Copy link
Member

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

main.js Outdated
@@ -4,7 +4,8 @@ const {
initPopupsConfigurationMain,
getPopupTarget,
RemoteControlMain,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul could you please fix this linter nit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

@saghul
Copy link
Member Author

saghul commented Dec 26, 2025

@saghul I tested it with macOS 15.7 and there the always-on-top / new pip does not work. Other than that, please fix the one nit from the linter, and I would still merge it anyway. If the pip is not working, I would accept that for the time being

What server did you test? If self-hosted, are you running the latest stable?

@csett86
Copy link
Member

csett86 commented Dec 26, 2025

@saghul I tested it with macOS 15.7 and there the always-on-top / new pip does not work. Other than that, please fix the one nit from the linter, and I would still merge it anyway. If the pip is not working, I would accept that for the time being

What server did you test? If self-hosted, are you running the latest stable?

Good hint, now retested on latest jitsi-meet stable, but still no luck. I also checked the devtools console from electron, unfortunately nothing visible there

@csett86
Copy link
Member

csett86 commented Dec 27, 2025

I just noticed, latest stable is from 24th November (https://github.com/jitsi/jitsi-meet/releases/tag/stable%2Fjitsi-meet_10655), so it does not include jitsi/jitsi-meet#16704, and thus probably cannot work...

With alpha.jitsi.net everything works as expected.

@csett86
Copy link
Member

csett86 commented Dec 27, 2025

(note to self for the release notes once I cut a release that includes this: Electron 38 (and with that also 39) drops support for macOS 11, and for linux, wayland is now used by default if running with wayland (ozone-platform-hint changing to auto): https://www.electronjs.org/blog/electron-38-0#breaking-changes)

@csett86 csett86 dismissed their stale review December 27, 2025 13:30

Incorporated

@csett86 csett86 merged commit 404660d into master Dec 27, 2025
3 checks passed
@csett86 csett86 deleted the sdk-9 branch December 27, 2025 13:30
@saghul
Copy link
Member Author

saghul commented Dec 27, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants