Open
Conversation
With electron/electron#49717 the desktopCapturer supports system audio for macOS 13 and above. Is was recently fixed in electron/electron#49740 for current electron. This is a preparational step, but: This on its own does not allow audio for screenshare, as its currently hard-coded to only show the "Share Audio" button on windows, see https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With electron/electron#49717 the desktopCapturer
supports system audio for macOS 13 and above. Is was recently fixed
in electron/electron#49740 for current
electron.
This is a preparational step, but:
This on its own does not allow audio for screenshare, as its currently
hard-coded to only show the "Share Audio" button on windows, see
https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34