-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger) send logs to aws #1030
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment, but also a larger one: how is the app going to know about the logging details?
@@ -28,6 +29,12 @@ require('./src/client-control'); | |||
require('./src/exit'); | |||
require('./src/volume-control'); | |||
|
|||
process.env.USE_CLOUDWATCH_LOGS && awsLogger.maybeCreateLogStream() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the Electron app going to get these env variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that the person that installs the app can set up these too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't work since the app is deployed fully packaged and the environment cannot be set just for that app, you'd need to launch it from the terminal or something.
I think the right thing to do is to use a JSON file which we can add in branding, and the code can read it from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the AWS credentials?
No description provided.