fix: remove adaptV4Theme and migrate to native MUI v5 theme structure #16294
+14,089
−2,060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Emoji
|
Hi, thanks for your contribution! |
feat: Add plugin head script inclusion to multiple HTML files fix
|
Does this have any practical implications? |
Yes — it addresses the deprecation warning from MUI regarding Practical implications include:
|
|
What I mean is: are there any implications such as visual changes because the change in theme structure? |
No, there aren't any visual changes introduced by this change. |
saghul
approved these changes
Aug 4, 2025
…ctly to close page (#49)
* fix(deploy): handle lib-jitsi-meet submodule * feat(host): use specific remote and local isHost functions * fix(tests): close invite dialog on meeting join
… feature for moderators (#60) * Add howler audio library dependency * Integrate Howler.js for sound management * Refactor sound system to use centralized SoundService * Fix trailing whitespace in SoundService.ts comment * Add Howler.js support * Implement unregister method for proper memory management * Replace sound-related Redux actions (playSound, registerSound, unregisterSound, stopSound) with direct SoundService calls across all middleware and components. * feat(SoundService): add muteSound method to SoundService for individual sound control * Remove unused SoundCollection component * Refactor sound system to centralize playback logic in SoundService * Remove unnecessary base sounds feature module * Replace 'any' with 'unknown' type in SoundService error handlers to fix typescript errors * Refactor sound system to pass state parameter to SoundService.play() and fix redux sound state * Add audio output device switching support to SoundService * Fix Typescript errors * fix lint error * Remove old sound middleware registration logic * Integrate sounds reducer with app state * Add 'optional' property to each sound in features/base/sounds redux store * Add sound muting functionality to base sounds feature * Refactor sound handling in settings components and integrate mute functionality * Update language files * lint lang files Remove unnecessary @types/howler dependency Revert "Remove unnecessary @types/howler dependency" This reverts commit 9e755d9. * Remove unused howler module declaration from globals.d.ts * Revert "Remove unused howler module declaration from globals.d.ts" This reverts commit 9a953e1. * Add global sound muting feature for moderators * add Sounds header in ModeratorTab Update mute sound label to use localized "Mute" text change Sound header to h4 * Refactor sound handling: streamline sound registration and localization * add 'moderation' property to sounds state * feat(sounds): implement sound localization in SoundService * create a single getLocalizedSound func to get both, localized sound and filepath * Refactor SoundService * create setMuteSoundGlobal function to send global sound mute command * fix(sounds): make sound file paths relative * Fix lint * remove unnecessary logs * pass in 'languages' prop when playing recording on and off sounds * fix(transcribing): add conference check before playing recording sound * Remove unneceassry sinkId param when initializing howler * fix lint * Fix lint * fix lint
* add refresh token --------- Co-authored-by: ibrahim ali <[email protected]>
…d full attendance (#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the usage of the deprecated
adaptV4Theme()helper and migrates the theme definition to MUI v5's nativecreateThemestructure.Why
MUI logs the following deprecation warning:
While
adaptV4Theme()was useful during the transition from MUI v4 to v5, it is no longer recommended and may be removed in future releases.What Changed
createTheme(adaptV4Theme(...))with direct usage ofcreateTheme(...)adaptV4ThemeimportResult