fix(prejoin): Handles different ways of disabling prejoin.#16897
Merged
fix(prejoin): Handles different ways of disabling prejoin.#16897
Conversation
damencho
force-pushed
the
fix-disable-gum
branch
from
c52b159 to
3d1aea9
Compare
saghul
approved these changes
Feb 3, 2026
damencho
force-pushed
the
fix-disable-gum
branch
4 times, most recently
from
546773a to
ba2b3bc
Compare
bgrozev
reviewed
Feb 3, 2026
| }); | ||
| }); | ||
|
|
||
| async function checkEveryoneMuted({ p1, p2 }: { p1: Participant; p2: Participant; }) { |
Member
There was a problem hiding this comment.
why the asymmetry -- p2 checks local and remote, p1 checks only remote?
bgrozev
approved these changes
Feb 3, 2026
damencho
force-pushed
the
fix-disable-gum
branch
from
776e6be to
ba7bbe4
Compare
Now handles using `config.prejoinConfig.enabled=false` and `config.prejoinConfig={enabled:false}.
Fixes #16892.
damencho
force-pushed
the
fix-disable-gum
branch
from
ba7bbe4 to
fd799cd
Compare
Member
Author
|
jenkins test this please |
damencho
force-pushed
the
fix-disable-gum
branch
7 times, most recently
from
3c69b3c to
bce853d
Compare
damencho
force-pushed
the
fix-disable-gum
branch
from
bce853d to
9ab20a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now handles using
config.prejoinConfig.enabled=falseand `config.prejoinConfig={enabled:false}.Fixes #16892.