Skip to content

fix: enable local recording when embedded in a same-domain iframe#16900

Merged
saghul merged 2 commits intojitsi:masterfrom
RidaElmaaroufi:fix/local-recording-iframe
Feb 11, 2026
Merged

fix: enable local recording when embedded in a same-domain iframe#16900
saghul merged 2 commits intojitsi:masterfrom
RidaElmaaroufi:fix/local-recording-iframe

Conversation

@RidaElmaaroufi
Copy link
Contributor

Description

This PR enables local recording when Jitsi Meet is embedded in an iframe whose parent is from the same domain.
In this case, the "Start recording" button is now displayed and local recording can be activated as it is considered a trusted embedding context.

Context

Previously, local recording was disabled whenever Jitsi Meet was running inside an iframe, regardless of whether the parent page was from the same domain.
This restriction was overly conservative for same-domain embeddings, where the security constraints of cross-domain iframes do not apply.

This change aligns the behavior with the web security model by allowing local recording in same-origin iframe scenarios, while keeping it disabled for cross-domain embeddings.

Implementation details

  • Introduced a same-domain embedding check to distinguish between same-origin and cross-origin iframe usage.
  • Updated the local recording capability check to allow recording when embedded in a same-domain iframe.

Testing

  • Web: verified that the "Start recording" button is displayed when Jitsi Meet is embedded in a same-domain iframe.
  • Web: verified that local recording remains disabled in cross-domain iframe scenarios.

@RidaElmaaroufi RidaElmaaroufi marked this pull request as ready for review February 4, 2026 16:01
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho damencho added the info:cla-signed The CLA has been signed label Feb 4, 2026
Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the lint errors, please.

@damencho
Copy link
Member

damencho commented Feb 6, 2026

Jenkins test this please.

@RidaElmaaroufi
Copy link
Contributor Author

Could you please merge?

@saghul saghul merged commit a06a338 into jitsi:master Feb 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:cla-signed The CLA has been signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants