fix: enable local recording when embedded in a same-domain iframe#16900
Merged
saghul merged 2 commits intojitsi:masterfrom Feb 11, 2026
Merged
fix: enable local recording when embedded in a same-domain iframe#16900saghul merged 2 commits intojitsi:masterfrom
saghul merged 2 commits intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
damencho
requested changes
Feb 4, 2026
Member
damencho
left a comment
There was a problem hiding this comment.
Fix the lint errors, please.
saghul
approved these changes
Feb 5, 2026
Member
|
Jenkins test this please. |
damencho
approved these changes
Feb 6, 2026
Contributor
Author
|
Could you please merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables local recording when Jitsi Meet is embedded in an iframe whose parent is from the same domain.
In this case, the "Start recording" button is now displayed and local recording can be activated as it is considered a trusted embedding context.
Context
Previously, local recording was disabled whenever Jitsi Meet was running inside an iframe, regardless of whether the parent page was from the same domain.
This restriction was overly conservative for same-domain embeddings, where the security constraints of cross-domain iframes do not apply.
This change aligns the behavior with the web security model by allowing local recording in same-origin iframe scenarios, while keeping it disabled for cross-domain embeddings.
Implementation details
Testing