Fix audio settings tab not updating UI on microphone permission change #16914
Open
mishraditi wants to merge 1 commit intojitsi:masterfrom
Open
Fix audio settings tab not updating UI on microphone permission change #16914mishraditi wants to merge 1 commit intojitsi:masterfrom
mishraditi wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Audio tab in the Settings dialog was not updating its UI when microphone permissions changed. After granting permission, the “Permission not granted” message remained visible until switching tabs, and after revoking permission, the message did not appear until re-entering the Audio tab. This PR ensures the Audio tab refreshes immediately on permission grant or revoke, keeping the UI in sync with the current permission state. Screenshots before and after the fix are attached.
Before :
Audio.Before.mp4
After :
Audio.After.mp4