fix(filmstrip) Excludes partially visible tiles for dominant speaker slot.#16916
Merged
jallamsetty1 merged 1 commit intomasterfrom Feb 9, 2026
Merged
fix(filmstrip) Excludes partially visible tiles for dominant speaker slot.#16916jallamsetty1 merged 1 commit intomasterfrom
jallamsetty1 merged 1 commit intomasterfrom
Conversation
damencho
approved these changes
Feb 9, 2026
| const maxFullyVisible = Math.floor(containerSize / itemSize); | ||
|
|
||
| // Fully visible count is the minimum of actual visible and max that can fit fully | ||
| // Ensure at least 1 if there are any visible items |
Member
There was a problem hiding this comment.
@jallamsetty1 This is not quite true!
I would say you either have maxFullyVisible (in this case currentVisibleCount=maxFullyVisible) or maxFullyVisible - 1 (in this case currentVisibleCount=maxFullyVisible+1) full tiles.
It looks like that on some cases you are counting the full tiles with one more (in the second case above).
| ? _thumbnailWidth + TILE_HORIZONTAL_MARGIN | ||
| : _thumbnailHeight + TILE_VERTICAL_MARGIN; | ||
| const containerSize = isHorizontal ? _filmstripWidth : _filmstripHeight; | ||
|
|
Member
There was a problem hiding this comment.
@jallamsetty1 Don't we have very similar logic somewhere?
Maybe we can reuse it?
Member
hristoterezov
left a comment
hristoterezov
left a comment
There was a problem hiding this comment.
@jallamsetty1 I'm wondering do we have the same issue on tile view? Should we do something similar? Have you explored this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.