fix: advance option in start recording#16948
Open
solomon17705cs wants to merge 1 commit intojitsi:masterfrom
Open
fix: advance option in start recording#16948solomon17705cs wants to merge 1 commit intojitsi:masterfrom
solomon17705cs wants to merge 1 commit intojitsi:masterfrom
Conversation
show Advanced Options for local recording setups
11 tasks
|
Hi, thanks for your contribution! |
Author
|
Oh, I see. Since this is my first contribution I don't know those rules. Now I completed the CLA process, can you check that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
Decoupled section visibility from transcription capability:
Advanced Options section now appears when:
Toggle behavior:
_canStartTranscribing()istrueImpact
Fixes
Fixes #16938