Skip to content

fix: advance option in start recording#16948

Open
solomon17705cs wants to merge 1 commit intojitsi:masterfrom
solomon17705cs:local-recording-advanced-options
Open

fix: advance option in start recording#16948
solomon17705cs wants to merge 1 commit intojitsi:masterfrom
solomon17705cs:local-recording-advanced-options

Conversation

@solomon17705cs
Copy link

## Problem

The "Advanced Options" section in the Start Recording dialog was hidden when transcription was disabled—even if recording capability (local) was available. This caused the section to be inaccessible in local-recording-only setups.

## Root Cause

Visibility of the entire **Advanced Options** section was gated exclusively by `_canStartTranscribing()`, which depends on:
- `transcription.enabled` in config
- JWT transcription permissions

### Root Cause Analysis

Original logic tightly coupled UI visibility to *transcription capability* instead of *recording capability*:

```javascript
// OLD CODE
if (selectedRecordingService !== RECORDING_TYPES.JITSI_REC_SERVICE 
    || !this._canStartTranscribing()) {
    return null; // Hide entire Advanced Options section
}
Screenshot 2026-02-15 at 10 33 03 PM

Solution

Decoupled section visibility from transcription capability:

// NEW CODE
const hasRecordingCapability = fileRecordingsServiceEnabled || _localRecordingAvailable;
const canStartTranscribing = this._canStartTranscribing();

// Show section if ANY capability exists (recording OR transcription)
if (!hasRecordingCapability && !canStartTranscribing) {
    return null;
}

// Conditionally render toggles within section
{canStartTranscribing && <TranscriptionToggle />}
<AudioVideoToggle /> // Always visible when section renders

Advanced Options section now appears when:

  • Cloud recording is available, OR
  • Local recording is available, OR
  • Transcription capability exists

Toggle behavior:

  • "Record transcription" toggle: Only visible when _canStartTranscribing() is true
  • "Record audio and video" toggle: Always visible when section is rendered

Impact

Screenshot 2026-02-15 at 11 14 31 PM
  • ✨ Fixes missing Advanced Options in local-recording-only environments
  • 🔒 Preserves existing transcription permission/validation logic
  • 🔄 Maintains current behavior for cloud recording (Jibri)
  • 🚫 Zero breaking changes to existing workflows

Fixes

Fixes #16938

show Advanced Options for local recording setups
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@solomon17705cs
Copy link
Author

Oh, I see. Since this is my first contribution I don't know those rules.

Now I completed the CLA process, can you check that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced Options missing in Recording Dialog for local recording only setups

2 participants