fix(external-api): prevent unload listener accumulation on SET_CONFIG#17246
Open
codewithabhay10 wants to merge 1 commit intojitsi:masterfrom
Open
fix(external-api): prevent unload listener accumulation on SET_CONFIG#17246codewithabhay10 wants to merge 1 commit intojitsi:masterfrom
codewithabhay10 wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #17245
Currently, the
SET_CONFIGmiddleware in the External API registers an anonymousunload(orbeforeunload) event listener every time it is dispatched:https://github.com/jitsi/jitsi-meet/blob/master/react/features/external-api/middleware.ts#L244
Because the handler is an anonymous function, the listeners accumulate over the lifecycle of a long-lived session if
SET_CONFIGis updated multiple times, leading to redundantnotifyConferenceLeftanddispose()calls on window unload.Description
This PR resolves the issue by hoisting the unload handler into module-level variables (
_locationand_unloadHandler).Before registering a new listener during the
SET_CONFIGdispatch, any previously registered listener is removed usingwindow.removeEventListener(). This ensures that exactly one unload listener exists at any given time.Testing Performed
SET_CONFIGno longer creates orphaned unload event listeners on thewindowobject.notifyConferenceLeft()anddispose()are gracefully executed exactly once.