feat(chat): implement XEP-0461 threaded reply UI#17322
Open
AmoghParmar wants to merge 1 commit intojitsi:masterfrom
Open
feat(chat): implement XEP-0461 threaded reply UI#17322AmoghParmar wants to merge 1 commit intojitsi:masterfrom
AmoghParmar wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds full reply-to support in the Jitsi Meet chat panel.
It captures
replyToIdfrom bothMESSAGE_RECEIVEDandPRIVATE_MESSAGE_RECEIVED, passes it through_onConferenceMessageReceived()and_handleReceivedMessage(), stores it asreplyToMessageIdin the reducer, and extendsIMessagewith the same field.It also adds reply state handling in the UI:
SET_REPLY_MESSAGEaction andsetReplyMessage()action creator.ChatInputwith a dismiss button.ChatMessage.Finally,
replyToMessageIdis passed throughsendMessage()andsendTextMessage()so XEP-0461 reply stanzas are sent over XMPP.Related Issue
#17196
Motivation and Context
This change adds the UI and state-management side of XEP-0461 threaded replies. The XMPP stanza construction fix is handled in
lib-jitsi-meet.How Has This Been Tested?
Manually tested the chat reply flow in Jitsi Meet. Verified that reply state appears in the input, reply previews render correctly, and reply messages are sent with the expected metadata.
Screenshots or GIF (In case of UI changes):
Before:

After:

Related PRs