feat: Add a URL template utility. #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage ? 42.27%
Complexity ? 267
=========================================
Files ? 59
Lines ? 2474
Branches ? 338
=========================================
Hits ? 1046
Misses ? 1354
Partials ? 74
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| } | ||
| } | ||
| should("throw an exception when the URI is invalid") { | ||
| val templatedUrl = TemplatedUrl("https://example.com/{{}}") |
There was a problem hiding this comment.
I take it this is relying on the fact than an unquoted { or } isn't valid anywhere in a URI?
JonathanLennox
approved these changes
Jun 16, 2025
|
|
||
| // Original template should not have the param saved | ||
| templatedUrl.set("param", "permanent") | ||
| templatedUrl.resolve() shouldBe URI("https://example.com/api?param=permanent") |
There was a problem hiding this comment.
I think this test would be more meaningful if you called the set of permanent before the resolve with temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.