Remove weak references from LogContext childContexts when the child is GC'd #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added. Should prevent unbounded growth of the context array for contexts with lots of short-lived children.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
============================================
+ Coverage 42.73% 42.91% +0.17%
- Complexity 276 278 +2
============================================
Files 60 60
Lines 2506 2512 +6
Branches 348 348
============================================
+ Hits 1071 1078 +7
Misses 1354 1354
+ Partials 81 80 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bgrozev
approved these changes
Sep 4, 2025
…by cleaners. Should prevent unbounded growth of the context array for contexts with lots of short-lived children, without requiring linear scans of existing subcontexts.
JonathanLennox
changed the title
bgrozev
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent unbounded growth of the context array for contexts with lots of short-lived children.