VideobridgeExpireThread is created but not started#2283
Merged
JonathanLennox merged 1 commit intojitsi:masterfrom Jan 22, 2025
Merged
VideobridgeExpireThread is created but not started#2283JonathanLennox merged 1 commit intojitsi:masterfrom
JonathanLennox merged 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
Member
|
Jenkins, test this please |
JonathanLennox
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @bgrozev! I'm not really sure whether it is a typo or done on purpose but I noticed that during
VideobridgeExpireThreadmove fromVideobridgetoMainin commit b623d6a call toVideobridgeExpireThread.start()was lost.Again, maybe it is done on purpose but in my deployment it leads to a weird situation that peers who lost connection are getting stuck in "reconnecting" state without being expired.