Skip to content

VideobridgeExpireThread is created but not started#2283

Merged
JonathanLennox merged 1 commit intojitsi:masterfrom
dsmeytis:expire_not_started
Jan 22, 2025
Merged

VideobridgeExpireThread is created but not started#2283
JonathanLennox merged 1 commit intojitsi:masterfrom
dsmeytis:expire_not_started

Conversation

@dsmeytis
Copy link
Contributor

Hello @bgrozev! I'm not really sure whether it is a typo or done on purpose but I noticed that during VideobridgeExpireThread move from Videobridge to Main in commit b623d6a call to VideobridgeExpireThread.start() was lost.
Again, maybe it is done on purpose but in my deployment it leads to a weird situation that peers who lost connection are getting stuck in "reconnecting" state without being expired.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@JonathanLennox
Copy link
Member

Jenkins, test this please

@JonathanLennox JonathanLennox merged commit 45a5258 into jitsi:master Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants