fix: Sources with type NONE should not have effective constraints#2292
Merged
fix: Sources with type NONE should not have effective constraints#2292
Conversation
Member
bgrozev
commented
Feb 21, 2025
bgrozev
commented
- fix: Sources with type NONE should not have effective constraints.
- squash: Adjust unit tests.
When a source has video type NONE or DISABLED, it has been signaled but is not transmitted. For the purpose of generating effective constraints, it should be as if the source was not present. A change of effective constraints is the trigger for creating a new mapping for a receiver. If a receiver has effective constraints for a source with type NONE, and that source is later enabled, the effective constraints don't change, and the mapping is not created. This should fix #2288.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2292 +/- ##
============================================
- Coverage 44.18% 44.16% -0.03%
- Complexity 2074 2076 +2
============================================
Files 350 350
Lines 19647 19679 +32
Branches 2652 2652
============================================
+ Hits 8682 8692 +10
- Misses 10083 10106 +23
+ Partials 882 881 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
JonathanLennox
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.