Skip to content

Various enhacements to timeseries debugging#2321

Merged
JonathanLennox merged 6 commits intojitsi:masterfrom
JonathanLennox:add-timeseries
Apr 28, 2025
Merged

Various enhacements to timeseries debugging#2321
JonathanLennox merged 6 commits intojitsi:masterfrom
JonathanLennox:add-timeseries

Conversation

@JonathanLennox
Copy link
Member

Added during new-BWE experimentation, but independent of it.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 14.49275% with 59 lines in your changes missing coverage. Please review.

Project coverage is 44.25%. Comparing base (ec7d461) to head (90c3b6a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ansform/node/outgoing/OutgoingStatisticsTracker.kt 0.00% 22 Missing ⚠️
...tsi/videobridge/cc/allocation/BitrateController.kt 0.00% 10 Missing ⚠️
...si/videobridge/cc/allocation/BandwidthAllocator.kt 10.00% 8 Missing and 1 partial ⚠️
...i/nlj/transform/node/outgoing/ProbingDataSender.kt 0.00% 6 Missing ⚠️
.../src/main/kotlin/org/jitsi/nlj/rtcp/NackHandler.kt 0.00% 5 Missing ⚠️
...nsform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt 75.00% 2 Missing ⚠️
...dge/cc/av1/Av1DDAdaptiveSourceProjectionContext.kt 0.00% 2 Missing ⚠️
...orm/src/main/kotlin/org/jitsi/nlj/RtpSenderImpl.kt 0.00% 1 Missing ⚠️
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 0.00% 1 Missing ⚠️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2321      +/-   ##
============================================
- Coverage     44.32%   44.25%   -0.08%     
- Complexity     2095     2097       +2     
============================================
  Files           351      351              
  Lines         19682    19734      +52     
  Branches       2660     2663       +3     
============================================
+ Hits           8724     8733       +9     
- Misses        10073    10115      +42     
- Partials        885      886       +1     
Files with missing lines Coverage Δ
...in/org/jitsi/nlj/transform/node/AudioRedHandler.kt 62.57% <100.00%> (+0.44%) ⬆️
...orm/src/main/kotlin/org/jitsi/nlj/RtpSenderImpl.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 23.46% <0.00%> (-0.05%) ⬇️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 19.15% <0.00%> (-0.04%) ⬇️
...nsform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt 41.05% <75.00%> (+3.12%) ⬆️
...dge/cc/av1/Av1DDAdaptiveSourceProjectionContext.kt 62.99% <0.00%> (-0.39%) ⬇️
.../src/main/kotlin/org/jitsi/nlj/rtcp/NackHandler.kt 0.00% <0.00%> (ø)
...i/nlj/transform/node/outgoing/ProbingDataSender.kt 0.00% <0.00%> (ø)
...si/videobridge/cc/allocation/BandwidthAllocator.kt 80.68% <10.00%> (-5.24%) ⬇️
...tsi/videobridge/cc/allocation/BitrateController.kt 50.70% <0.00%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7d461...90c3b6a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


enum class PacketType {
Routed,
RTX,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have RTX sent for probing marked as Padding, and plain retransmissions marked as RTX. Suggest renaming RTX -> Retransmission and Padding -> Probing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new Google CC (which motivated this work), there's separate probing technique (send a short burst of data very fast and measure how quickly it's received) which is different than our padding probing, so I'd like to keep the name "Padding" here. Ok on the RTX.

@JonathanLennox JonathanLennox merged commit 18ad483 into jitsi:master Apr 28, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants