Various enhacements to timeseries debugging#2321
Merged
JonathanLennox merged 6 commits intojitsi:masterfrom Apr 28, 2025
Merged
Various enhacements to timeseries debugging#2321JonathanLennox merged 6 commits intojitsi:masterfrom
JonathanLennox merged 6 commits intojitsi:masterfrom
Conversation
bgrozev
requested changes
Apr 28, 2025
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt
Outdated
Show resolved
Hide resolved
|
|
||
| enum class PacketType { | ||
| Routed, | ||
| RTX, |
Member
There was a problem hiding this comment.
We have RTX sent for probing marked as Padding, and plain retransmissions marked as RTX. Suggest renaming RTX -> Retransmission and Padding -> Probing.
Member
Author
There was a problem hiding this comment.
In the new Google CC (which motivated this work), there's separate probing technique (send a short burst of data very fast and measure how quickly it's received) which is different than our padding probing, so I'd like to keep the name "Padding" here. Ok on the RTX.
...transform/src/main/kotlin/org/jitsi/nlj/transform/node/outgoing/OutgoingStatisticsTracker.kt
Show resolved
Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt
Outdated
Show resolved
Hide resolved
jitsi-media-transform/src/main/kotlin/org/jitsi/nlj/PacketInfo.kt
Outdated
Show resolved
Hide resolved
bgrozev
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added during new-BWE experimentation, but independent of it.