Skip to content

Add activeDecodeTargets to AV1 DD JSON description#2322

Merged
JonathanLennox merged 2 commits intojitsi:masterfrom
JonathanLennox:enhance-av1-dd-json
Apr 28, 2025
Merged

Add activeDecodeTargets to AV1 DD JSON description#2322
JonathanLennox merged 2 commits intojitsi:masterfrom
JonathanLennox:enhance-av1-dd-json

Conversation

@JonathanLennox
Copy link
Member

(This is only used for debug output.)

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.24%. Comparing base (ec7d461) to head (93d73c5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...tensions/Av1DependencyDescriptorHeaderExtension.kt 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2322      +/-   ##
============================================
- Coverage     44.32%   44.24%   -0.09%     
- Complexity     2095     2097       +2     
============================================
  Files           351      351              
  Lines         19682    19739      +57     
  Branches       2660     2666       +6     
============================================
+ Hits           8724     8733       +9     
- Misses        10073    10120      +47     
- Partials        885      886       +1     
Files with missing lines Coverage Δ
...tensions/Av1DependencyDescriptorHeaderExtension.kt 73.90% <0.00%> (-0.72%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7d461...93d73c5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

customChains?.let { put("customChains", it) }
activeDecodeTargetsBitmask?.let {
if (newTemplateDependencyStructure == null ||
activeDecodeTargetsBitmask != ((1 shl newTemplateDependencyStructure.decodeTargetCount) - 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the check does, but it should use the it reference

@JonathanLennox JonathanLennox merged commit f5b6c90 into jitsi:master Apr 28, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants