Skip to content

chore: Remove inactive pre-commit hook configuration#80

Merged
hristoterezov merged 1 commit intomasterfrom
chore/remove-inactive-precommit-hooks
Oct 17, 2025
Merged

chore: Remove inactive pre-commit hook configuration#80
hristoterezov merged 1 commit intomasterfrom
chore/remove-inactive-precommit-hooks

Conversation

@hristoterezov
Copy link
Member

Summary

Removes the non-functional pre-commit hook configuration from package.json.

Problem

The package.json contained a pre-commit field that referenced lint and test scripts:

"pre-commit": [
  "lint",
  "test"
],

However, this configuration was not functional because:

  • The pre-commit npm package was not installed in devDependencies
  • No git hooks were active in .git/hooks/
  • Testing confirmed commits succeeded without running lint checks

This created confusion about whether pre-commit checks were enforced.

Changes

  • Removed pre-commit field from package.json

Alternative Quality Checks

Developers should:

  • Manually run npm run lint before committing (as they currently must do)
  • Rely on CI pipeline which already enforces linting on pull requests

Test Plan

  • Verified package.json is valid JSON after removal
  • Confirmed npm commands still work (npm run lint, npm run build)
  • Tested that commits work normally (they already did, but now it's clear why)

Removes the pre-commit hook configuration from package.json as it was not
functional. The configuration referenced lint and test scripts but the
required pre-commit npm package was not installed, so the hooks were
never actually executed.

Developers should manually run 'npm run lint' before committing, and the
CI pipeline already enforces linting on pull requests, providing the
necessary quality checks.
@hristoterezov hristoterezov merged commit 24b0cf6 into master Oct 17, 2025
1 check passed
@hristoterezov hristoterezov deleted the chore/remove-inactive-precommit-hooks branch October 17, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants