feat(subject): Avoids setting subject if already set.#2615
Merged
Conversation
jallamsetty1
approved these changes
Jan 13, 2025
modules/xmpp/ChatRoom.js
Outdated
| * @param subject | ||
| */ | ||
| setSubject(subject) { | ||
| if ((subject || subject === '') |
Member
There was a problem hiding this comment.
I'm wondering shouldn't we handle the cases when subject is undefined?
I guess we would at least want to still compare if the old value was undefined to not send an xmpp stanza.
damencho
force-pushed
the
skip-setting-subject
branch
from
ee1308e to
2255d3c
Compare
damencho
force-pushed
the
skip-setting-subject
branch
from
2255d3c to
1f59d83
Compare
hristoterezov
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.