Skip to content

ref: AVModeration to use typescript#2642

Merged
saghul merged 9 commits intojitsi:masterfrom
manzil-infinity180:AVModeration
Mar 23, 2025
Merged

ref: AVModeration to use typescript#2642
saghul merged 9 commits intojitsi:masterfrom
manzil-infinity180:AVModeration

Conversation

@manzil-infinity180
Copy link
Contributor

@manzil-infinity180 manzil-infinity180 commented Feb 15, 2025 •
edited
Loading

@jitsi-jenkins
Copy link

jitsi-jenkins commented Feb 15, 2025

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Feb 17, 2025

Ran the CI.

@manzil-infinity180
Copy link
Contributor Author

manzil-infinity180 commented Feb 19, 2025

@saghul is this ready to merge !!

saghul
saghul reviewed Feb 19, 2025
View reviewed changes
modules/xmpp/AVModeration.ts Outdated
import { getLogger } from '@jitsi/logger';
import { $msg } from 'strophe.js';

import ChatRoom from "./ChatRoom";
Copy link
Member

@saghul saghul Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh I'm not sure why the linger didn't catch this.

Can you please make it single quotes?

Also put it right before the XMPP import please.

I'll look into what's up with the linter...

manzil-infinity180
manzil-infinity180 commented Feb 20, 2025
View reviewed changes
@saghul
Copy link
Member

saghul commented Mar 13, 2025

Jenkins please test this please.

@saghul
Copy link
Member

saghul commented Mar 20, 2025

Can you please rebase?

@manzil-infinity180
Copy link
Contributor Author

manzil-infinity180 commented Mar 21, 2025

PTAL @saghul

@saghul
Copy link
Member

saghul commented Mar 21, 2025

The CI is running now, I did see some errors the linter will catch.

saghul
saghul requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the CI is happy :-)

@saghul
Copy link
Member

saghul commented Mar 22, 2025

Jenkins please test this please.

@manzil-infinity180
Copy link
Contributor Author

manzil-infinity180 commented Mar 23, 2025

@saghul i fixed the lint error

@saghul
Copy link
Member

saghul commented Mar 23, 2025

Jenkins please test this please.

@saghul saghul merged commit 34807ff into jitsi:master Mar 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saghul saghul saghul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manzil-infinity180 @jitsi-jenkins @saghul